OSDN Git Service

qlogic: qlcnic: fix use of SPEED_UNKNOWN ethtool constant
authorMichael Zhivich <mzhivich@akamai.com>
Mon, 8 Apr 2019 14:48:47 +0000 (10:48 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Apr 2019 23:30:43 +0000 (16:30 -0700)
commitd63da85a4226c4b5a28536a1f48d89eefd50a832
tree7892ecd5ae2e837e12153cef6ee42879214fc198
parentcaf2c5205d82ff0d758096a69a7e0466c38d4dbb
qlogic: qlcnic: fix use of SPEED_UNKNOWN ethtool constant

qlcnic driver uses u16 to store SPEED_UKNOWN ethtool constant,
which is defined as -1, resulting in value truncation and
thus incorrect test results against SPEED_UNKNOWN.

For example, the following test will print "False":

    u16 speed = SPEED_UNKNOWN;

    if (speed == SPEED_UNKNOWN)
        printf("True");
    else
        printf("False");

Change storage of speed to use u32 to avoid this issue.

Signed-off-by: Michael Zhivich <mzhivich@akamai.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic.h