OSDN Git Service

drm/i915: Use drm_dev_unplug()
authorJanusz Krzysztofik <janusz.krzysztofik@intel.com>
Fri, 5 Apr 2019 13:02:34 +0000 (15:02 +0200)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 19 Apr 2019 10:23:59 +0000 (11:23 +0100)
commitd69990e0c399e4f7f9b50505d3285e5de991148a
tree52ad4f97bd88a0cd84db021d55f9a645d20aee1a
parent844e33135d3a17686e167af2b6e653a4721c26e5
drm/i915: Use drm_dev_unplug()

The driver does not currently support unbinding from a device which is
in use.  Since open file descriptors may still be pointing into kernel
memory where the device structures used to be, entirely correct kernel
panics protect the driver from being unbound as we should not be
unbinding it before those dangling pointers have been made safe.

According to the documentation found inside drivers/gpu/drm/drm_drv.c,
drm_dev_unplug() should be used instead of drm_dev_unregister() in
order to make a device inaccessible to users as soon as it is unpluged.
Follow that advice to make those possibly dangling pointers safe,
protected by DRM layer from a user who is otherwise left pointing into
possibly reused kernel memory after the driver has been unbound from
the device.  Once done, also cancel inflight operations immediately by
calling i915_gem_set_wedged().

Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20190405130235.7707-2-janusz.krzysztofik@linux.intel.com
drivers/gpu/drm/i915/i915_drv.c