OSDN Git Service

ksz884x: don't copy too much in netdev_set_mac_address()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 19 Apr 2012 07:00:19 +0000 (10:00 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Apr 2012 16:51:21 +0000 (09:51 -0700)
commitd76556549e7a97c25269644afd0b1b18a6c42214
treec0f87cf2070154aa55391407385bb63a4ca659bc
parent0958c122f47f4ef2a1ae552fed56a8bf8502c32b
ksz884x: don't copy too much in netdev_set_mac_address()

[ Upstream commit 716af4abd6e6370226f567af50bfaca274515980 ]

MAX_ADDR_LEN is 32.  ETH_ALEN is 6.  mac->sa_data is a 14 byte array, so
the memcpy() is doing a read past the end of the array.  I asked about
this on netdev and Ben Hutchings told me it's supposed to be copying
ETH_ALEN bytes (thanks Ben).

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ksz884x.c