OSDN Git Service

media: v4l2-ctrl: potential shift wrapping bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 25 Mar 2019 09:06:26 +0000 (05:06 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 29 Mar 2019 11:40:45 +0000 (07:40 -0400)
commitd7a955c8ef7cd8fecfd9e900c47f72e67dfcc49a
tree51bcaba2f9b4419dc395ff0ccf74791f95ca17cc
parent0e633f97162c1c74c68e2eb20bbd9259dce87cd9
media: v4l2-ctrl: potential shift wrapping bugs

This code generates a static checker warning:

    drivers/media/v4l2-core/v4l2-ctrls.c:2921 v4l2_querymenu()
    warn: should '(1 << i)' be a 64 bit type?

The problem is that "ctrl->menu_skip_mask" is a u64 and we're only
testing the lower 32 bits.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/v4l2-core/v4l2-ctrls.c