OSDN Git Service

libata: transport: Remove circular dependency at free time
authorGwendal Grignou <gwendal@chromium.org>
Fri, 3 Mar 2017 17:00:09 +0000 (09:00 -0800)
committerTejun Heo <tj@kernel.org>
Mon, 6 Mar 2017 20:24:48 +0000 (15:24 -0500)
commitd85fc67dd11e9a32966140677d4d6429ca540b25
treefaf40259eb99fc42941b828a7870fbff6f012146
parentc1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201
libata: transport: Remove circular dependency at free time

Without this patch, failed probe would not free resources like irq.

ata port tdev object currently hold a reference to the ata port
object.  Therefore the ata port object release function will not get
called until the ata_tport_release is called. But that would never
happen, releasing the last reference of ata port dev is done by
scsi_host_release, which is called by ata_host_release when the ata
port object is released.

The ata device objects actually do not need to explicitly hold a
reference to their real counterpart, given the transport objects are
the children of these objects and device_add() is call for each child.
We know the parent will not be deleted until we call the child's
device_del().

Reported-by: Matthew Whitehead <tedheadster@gmail.com>
Tested-by: Matthew Whitehead <tedheadster@gmail.com>
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libata-transport.c