OSDN Git Service

net: hns: use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 26 Feb 2019 00:27:57 +0000 (18:27 -0600)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Feb 2019 05:47:42 +0000 (21:47 -0800)
commitd89ea4acfc039f6968f8b5a1dfae5d3cbf611444
tree189e787223f6110ceaa30325479a683526859535
parentd8afbc9795a5d05f1ca47a3ee817d2c07f3d7efe
net: hns: use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(struct boo) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c