OSDN Git Service

net: stmmac: do not use a bitwise AND operator with a bool operand
authorNiklas Cassel <niklas.cassel@axis.com>
Mon, 22 Jan 2018 15:59:50 +0000 (16:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Jan 2018 21:28:07 +0000 (16:28 -0500)
commitd8f8b9542a4d8d560c0292a492f4edd922dd4ece
tree79b535640308b6e1b9869f235f0b01c20c2b0230
parent98fe9cd7822167ab9d5080c8b99aef261819c48a
net: stmmac: do not use a bitwise AND operator with a bool operand

Doing a bitwise AND between a bool and an int is generally not a good idea.
The bool will be promoted to an int with value 0 or 1,
the int is generally regarded as true with a non-zero value,
thus ANDing them has the potential to yield an undesired result.

This commit fixes the following smatch warnings:

drivers/net/ethernet/stmicro/stmmac/enh_desc.c:344 enh_desc_prepare_tx_desc() warn: maybe use && instead of &
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:337 dwmac4_rd_prepare_tx_desc() warn: maybe use && instead of &
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c:380 dwmac4_rd_prepare_tso_tx_desc() warn: maybe use && instead of &

Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
drivers/net/ethernet/stmicro/stmmac/enh_desc.c