OSDN Git Service

multi-process: Initialize variables declared with g_auto*
authorZenghui Yu <yuzenghui@huawei.com>
Fri, 12 Mar 2021 11:21:43 +0000 (19:21 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 21 May 2021 14:43:57 +0000 (15:43 +0100)
commitd90226808b5b1b30b07968e94d8f74bf8804fc89
tree09431e51cdb86a08cd3b3f1371d3d49b934a1dc4
parent6c769690ac845fa62642a5f93b4e4bd906adab95
multi-process: Initialize variables declared with g_auto*

Quote docs/devel/style.rst (section "Automatic memory deallocation"):

* Variables declared with g_auto* MUST always be initialized,
  otherwise the cleanup function will use uninitialized stack memory

Initialize @name properly to get rid of the compilation error (using
gcc-7.3.0 on CentOS):

../hw/remote/proxy.c: In function 'pci_proxy_dev_realize':
/usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: 'name' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   g_free (*pp);
   ^~~~~~~~~~~~
../hw/remote/proxy.c:350:30: note: 'name' was declared here
             g_autofree char *name;
                              ^~~~

Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Miroslav Rezanina <mrezanin@redhat.com>
Message-id: 20210312112143.1369-1-yuzenghui@huawei.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/remote/memory.c
hw/remote/proxy.c