OSDN Git Service

OPP: Fix passing 0 to PTR_ERR in _opp_attach_genpd()
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fri, 21 Jul 2023 12:46:34 +0000 (18:16 +0530)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 24 Jul 2023 08:01:25 +0000 (13:31 +0530)
commitd920920f85a82c1c806a4143871a0e8f534732f2
treefc60273abd480dfa354896a86a1ce86ee039e0d5
parent7ddd8deb1c3c0363a7e14fafb5df26e2089a69a5
OPP: Fix passing 0 to PTR_ERR in _opp_attach_genpd()

If dev_pm_domain_attach_by_name() returns NULL, then 0 will be passed to
PTR_ERR() as reported by the smatch warning below:

drivers/opp/core.c:2456 _opp_attach_genpd() warn: passing zero to 'PTR_ERR'

Fix it by checking for the non-NULL virt_dev pointer before passing it to
PTR_ERR. Otherwise return -ENODEV.

Fixes: 4ea9496cbc95 ("opp: Fix error check in dev_pm_opp_attach_genpd()")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/core.c