OSDN Git Service

scsi: aacraid: Perform initialization reset only once
authorGuilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Fri, 17 Nov 2017 21:14:54 +0000 (19:14 -0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 21 Nov 2017 03:32:00 +0000 (22:32 -0500)
commitd9b6d85a38df398cfe0ba3f0fae59d58c9a6d433
treec7a49351b61738ca915811eded5f07b8bdbbe132
parentbd257b2f3bc68514fad19763f540fea581c12d22
scsi: aacraid: Perform initialization reset only once

Currently the driver accepts two ways of requesting an initialization
reset on the adapter: by passing aac_reset_devices module parameter,
or the generic kernel parameter reset_devices.

It's working as intended...but if we end up reaching a scsi hang and
the scsi EH mechanism takes place, aacraid performs resets as part of
the scsi error recovery procedure. These EH routines might reinitialize
the device, and if we have provided some of the reset parameters in the
kernel command-line, we again perform an "initialization" reset.

So, to avoid this duplication of resets in case of scsi EH path, this
patch adds a field to aac_dev struct to keep per-adapter track of the
init reset request - once it's done, we set it to false and don't
proactively reset anymore in case of reinitializations.

Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aacraid/aacraid.h
drivers/scsi/aacraid/linit.c
drivers/scsi/aacraid/rx.c
drivers/scsi/aacraid/src.c