OSDN Git Service

scsi: sg: sg_new_write(): don't bother with access_ok
authorAl Viro <viro@zeniv.linux.org.uk>
Thu, 17 Oct 2019 19:39:22 +0000 (20:39 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 6 Nov 2019 05:04:03 +0000 (00:04 -0500)
commitd9fc5617bcb6f8278ffedd0f25bfbb697da5ca87
tree675b821667fa27f235ef8e95cd2487baa0b83b3f
parentc35a5cfb41509c2214228aa321509ffd91cbf063
scsi: sg: sg_new_write(): don't bother with access_ok

... just use copy_from_user().  We copy only SZ_SG_IO_HDR bytes, so that
would, strictly speaking, loosen the check.  However, for call chains via
->write() the caller has actually checked the entire range and SG_IO passes
exactly SZ_SG_IO_HDR for count.  So no visible behaviour changes happen if
we check only what we really need for copyin.

Link: https://lore.kernel.org/r/20191017193925.25539-5-viro@ZenIV.linux.org.uk
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sg.c