OSDN Git Service

scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()
authorCan Guo <cang@codeaurora.org>
Tue, 3 Nov 2020 06:24:39 +0000 (22:24 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 5 Nov 2020 04:13:33 +0000 (23:13 -0500)
commitda3fecb0040324c08f1587e5bff1f15f36be1872
tree34a24460b616963f2012b9da2509ff80c4d4fc9a
parent5feed64f9199ff90c4239971733f23f30aeb2484
scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

The scsi_block_reqs_cnt increased in ufshcd_hold() is supposed to be
decreased back in ufshcd_ungate_work() in a paired way. However, if
specific ufshcd_hold/release sequences are met, it is possible that
scsi_block_reqs_cnt is increased twice but only one ungate work is
queued. To make sure scsi_block_reqs_cnt is handled by ufshcd_hold() and
ufshcd_ungate_work() in a paired way, increase it only if queue_work()
returns true.

Link: https://lore.kernel.org/r/1604384682-15837-2-git-send-email-cang@codeaurora.org
Reviewed-by: Hongwu Su <hongwus@codeaurora.org>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c