OSDN Git Service

drm/nouveau/pmu: don't print reply values if exec is false
authorColin Ian King <colin.king@canonical.com>
Wed, 19 Dec 2018 15:29:49 +0000 (15:29 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:21:40 +0000 (10:21 +0100)
commitdac3ac0c9c146f9de4a6eb5c9d71365dde95bb16
tree881495ac2d092abea2f1eec9cea15f958baaeeb8
parentc83057a12e352608bfc490c044ba8954946b5a39
drm/nouveau/pmu: don't print reply values if exec is false

[ Upstream commit b1d03fc36ec9834465a08c275c8d563e07f6f6bf ]

Currently the uninitialized values in the array reply are printed out
when exec is false and nvkm_pmu_send has not updated the array. Avoid
confusion by only dumping out these values if they have been actually
updated.

Detected by CoverityScan, CID#1271291 ("Uninitialized scaler variable")
Fixes: ebb58dc2ef8c ("drm/nouveau/pmu: rename from pwr (no binary change)")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/nouveau/nvkm/subdev/pmu/memx.c