OSDN Git Service

misc: xilinx_sdfec: Fix a couple small information leaks
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 21 Aug 2019 07:06:06 +0000 (10:06 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Aug 2019 21:28:09 +0000 (14:28 -0700)
commitdac4f1964a9cbfbf81df8d31caa04ced0d7613b5
tree52b3e79e32465590775f172e1106ae798df08ee3
parente70c971d7d8ac5b19fea1c2fde0290bcf7881946
misc: xilinx_sdfec: Fix a couple small information leaks

These structs have holes in them so we end up disclosing a few bytes of
uninitialized stack data.

drivers/misc/xilinx_sdfec.c:305 xsdfec_get_status() warn: check that 'status' doesn't leak information (struct has a hole after 'activity')
drivers/misc/xilinx_sdfec.c:449 xsdfec_get_turbo() warn: check that 'turbo_params' doesn't leak information (struct has a hole after 'scale')

We need to zero out the holes with memset().

Fixes: 6bd6a690c2e7 ("misc: xilinx_sdfec: Add stats & status ioctls")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/20190821070606.GA26957@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/xilinx_sdfec.c