OSDN Git Service

net: ethernet: stmmac: dwmac-rk: fix optional phy regulator handling
authorSebastian Reichel <sebastian.reichel@collabora.com>
Fri, 7 Apr 2023 16:11:29 +0000 (18:11 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Apr 2023 08:21:27 +0000 (09:21 +0100)
commitdb21973263f8c56750cb610f1d5e8bee00a513b9
treea696415859c1f5cc8da78dec1f0d7360d436f353
parentea449f7fa0bf3fcd02e04a770b9ff707bf5e8f96
net: ethernet: stmmac: dwmac-rk: fix optional phy regulator handling

The usual devm_regulator_get() call already handles "optional"
regulators by returning a valid dummy and printing a warning
that the dummy regulator should be described properly. This
code open coded the same behaviour, but masked any errors that
are not -EPROBE_DEFER and is quite noisy.

This change effectively unmasks and propagates regulators errors
not involving -ENODEV, downgrades the error print to warning level
if no regulator is specified and captures the probe defer message
for /sys/kernel/debug/devices_deferred.

Fixes: 2e12f536635f ("net: stmmac: dwmac-rk: Use standard devicetree property for phy regulator")
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c