OSDN Git Service

drm/vc4: hdmi: Disable audio if dmas property is present but empty
authorPhil Elwell <phil@raspberrypi.org>
Mon, 13 Jun 2022 14:47:44 +0000 (16:47 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Tue, 28 Jun 2022 12:55:41 +0000 (14:55 +0200)
commitdb2b927f8668adf3ac765e0921cd2720f5c04172
tree3e61cf24b21f4bac55ce76e7bdf02fdc68e1e618
parent7bcb9c8d0bc9f3cab8ac2634b056c2e6b63945ca
drm/vc4: hdmi: Disable audio if dmas property is present but empty

The dmas property is used to hold the dmaengine channel used for audio
output.

Older device trees were missing that property, so if it's not there we
disable the audio output entirely.

However, some overlays have set an empty value to that property, mostly
to workaround the fact that overlays cannot remove a property. Let's add
a test for that case and if it's empty, let's disable it as well.

Cc: <stable@vger.kernel.org>
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Link: https://lore.kernel.org/r/20220613144800.326124-18-maxime@cerno.tech
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
drivers/gpu/drm/vc4/vc4_hdmi.c