OSDN Git Service

ALSA: memalloc: don't use GFP_COMP for non-coherent dma allocations
authorChristoph Hellwig <hch@lst.de>
Tue, 20 Dec 2022 08:05:36 +0000 (09:05 +0100)
committerChristoph Hellwig <hch@lst.de>
Wed, 21 Dec 2022 07:45:17 +0000 (08:45 +0100)
commitdb918321275d648294a3fb2bdefeb99e33f00467
tree0e413d82500070cfe72f05ee03717f51629bbd76
parent6feb57c2fd7c787aecf2846a535248899e7b70fa
ALSA: memalloc: don't use GFP_COMP for non-coherent dma allocations

While not quite as bogus as for the dma-coherent allocations that were
fixed earlier, GFP_COMP for these allocations has no benefits for
the dma-direct case, and can't be supported at all by dma dma-iommu
backend which splits up allocations into smaller orders.  Due to an
oversight in ffcb75458460 that flag stopped being cleared for all
dma allocations, but only got rejected for coherent ones.

Start fixing this by not requesting __GFP_COMP in the sound code, which
is the only place that did this.

Fixes: ffcb75458460 ("dma-mapping: reject __GFP_COMP in dma_alloc_attrs")
Reported-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Reported-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Tested-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
sound/core/memalloc.c