OSDN Git Service

netfilter: ipt_CLUSTERIP: fix a refcount bug in clusterip_config_find_get()
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 8 Feb 2018 21:53:52 +0000 (13:53 -0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 14 Feb 2018 20:05:32 +0000 (21:05 +0100)
commitdb93a3632b0f8773a3899e04a3a3e0aa7a26eb46
tree326e1da2fc4b76761b74712758a4fa84d7aacdce
parent57ebd808a97d7c5b1e1afb937c2db22beba3c1f8
netfilter: ipt_CLUSTERIP: fix a refcount bug in clusterip_config_find_get()

In clusterip_config_find_get() we hold RCU read lock so it could
run concurrently with clusterip_config_entry_put(), as a result,
the refcnt could go back to 1 from 0, which leads to a double
list_del()... Just replace refcount_inc() with
refcount_inc_not_zero(), as for c->refcount.

Fixes: d73f33b16883 ("netfilter: CLUSTERIP: RCU conversion")
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv4/netfilter/ipt_CLUSTERIP.c