OSDN Git Service

hwmon: (nzxt-smart2) handle failure of devm_add_action in nzxt_smart2_hid_probe
authorKang Chen <void0red@gmail.com>
Mon, 27 Feb 2023 09:15:34 +0000 (17:15 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 19 Apr 2023 14:08:31 +0000 (07:08 -0700)
commitdbfeafdad31c52da8965819a298ed3b0127025e7
treece5c2c22c84c40aad002a70d8a5be99c95f8411c
parent37ef30fbf2894e1acd5aa7cc1dccfc54039cecd5
hwmon: (nzxt-smart2) handle failure of devm_add_action in nzxt_smart2_hid_probe

1. replace the devm_add_action with devm_add_action_or_reset to ensure
the mutex lock can be destroyed when it fails.
2. use local wrapper function mutex_fini instead of mutex_destroy to
avoid undefined behaviours.
3. add a check of devm_add_action_or_reset and return early when it fails.

Link: https://lore.kernel.org/all/f5043281-9b3e-e454-16fe-ef4cde36dfdb@roeck-us.net
Signed-off-by: Kang Chen <void0red@gmail.com>
Link: https://lore.kernel.org/r/20230227091534.907101-1-void0red@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/nzxt-smart2.c