OSDN Git Service

serial/sunsu: fix refcount leak
authorYangtao Li <tiny.windzz@gmail.com>
Wed, 12 Dec 2018 16:01:45 +0000 (11:01 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Jan 2019 08:51:03 +0000 (09:51 +0100)
commitdc68052427be094c97be535710a29764bf633430
tree0ca50425dfd5727aa7385b8662b07d5687e4bbc0
parent08e7661cdd560ff290350d124d09be204d87acec
serial/sunsu: fix refcount leak

[ Upstream commit d430aff8cd0c57502d873909c184e3b5753f8b88 ]

The function of_find_node_by_path() acquires a reference to the node
returned by it and that reference needs to be dropped by its caller.

su_get_type() doesn't do that. The match node are used as an identifier
to compare against the current node, so we can directly drop the refcount
after getting the node from the path as it is not used as pointer.

Fix this by use a single variable and drop the refcount right after
of_find_node_by_path().

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/serial/sunsu.c