OSDN Git Service

e1000: Don't set the Capabilities List bit
authordann frazier <dann.frazier@canonical.com>
Wed, 21 Sep 2011 20:06:25 +0000 (14:06 -0600)
committerAnthony Liguori <aliguori@us.ibm.com>
Fri, 23 Sep 2011 15:55:32 +0000 (10:55 -0500)
commitdd8e93799f13ef82d83c185b8e71e049452f7d40
tree712e683c5dd95b8c5afc317a98c8398b607b0f2e
parent74e26c179efa6eed821c2863b8a50c7b586432c4
e1000: Don't set the Capabilities List bit

[Originally sent to qemu-kvm list, but I was redirected here]

The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of
this bit doesn't appear to change any behavior on Linux/Windows versions we've
tested, but it does cause Windows' PCI/PCI Express Compliance Test to balk.

I happen to have a physical 82540EM controller, and it also sets the
Capabilities Bit, but it actually has items on the capabilities list to go
with it :)

Signed-off-by: dann frazier <dann.frazier@canonical.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/e1000.c