OSDN Git Service

staging: rtl8188eu: fix possible null dereference
authorConnor Kuehl <connor.kuehl@canonical.com>
Thu, 26 Sep 2019 15:03:17 +0000 (08:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Dec 2019 15:34:49 +0000 (16:34 +0100)
commitdd97f971bee39389f60a21ded134c20b06f6e4d8
treee21a0b64f9b6f98d6645fa176aa22c4973989bd7
parent69af5fc1c70d5eae901a5b537fc4d53ede7d594b
staging: rtl8188eu: fix possible null dereference

[ Upstream commit 228241944a48113470d3c3b46c88ba7fbe0a274b ]

Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else if' where 'psta' is dereferenced, then we will dereference
a NULL pointer.

Fix this by checking if 'psta' is not NULL before reading its
'psta->qos_option' data member.

Addresses-Coverity: ("Dereference null return value")

Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Link: https://lore.kernel.org/r/20190926150317.5894-1-connor.kuehl@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/rtl8188eu/core/rtw_xmit.c