OSDN Git Service

net: phylink: require supported_interfaces to be filled
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sat, 20 May 2023 10:41:42 +0000 (11:41 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 23 May 2023 02:07:42 +0000 (19:07 -0700)
commitde5c9bf40c4582729f64f66d9cf4920d50beb897
tree7825b4dfb98c6a718f4231250402d0ba21e7e6ef
parent5859a99b52254be356d3cca2e40f7f371ef24b0a
net: phylink: require supported_interfaces to be filled

We have been requiring the supported_interfaces bitmap to be filled in
by MAC drivers that have a mac_select_pcs() method. Now that all MAC
drivers fill in the supported_interfaces bitmap, it is time to enforce
this. We have already required supported_interfaces to be set in order
for optical SFPs to be configured in commit f81fa96d8a6c ("net: phylink:
use phy_interface_t bitmaps for optical modules").

Refuse phylink creation if supported_interfaces is empty, and remove
code to deal with cases where this mask is empty.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/E1q0K1u-006EIP-ET@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phylink.c