OSDN Git Service

x86/mce/inject: Avoid out-of-bounds write when setting flags
authorZhang Zixun <zhang133010@icloud.com>
Mon, 27 Dec 2021 21:02:49 +0000 (22:02 +0100)
committerBorislav Petkov <bp@suse.de>
Tue, 28 Dec 2021 10:45:36 +0000 (11:45 +0100)
commitde768416b203ac84e02a757b782a32efb388476f
tree5ee61304bbe1f96dd423ef8e79749eda56ada6bc
parent91f75eb481cfaee5c4ed8fb5214bf2fbfa04bd7b
x86/mce/inject: Avoid out-of-bounds write when setting flags

A contrived zero-length write, for example, by using write(2):

  ...
  ret = write(fd, str, 0);
  ...

to the "flags" file causes:

  BUG: KASAN: stack-out-of-bounds in flags_write
  Write of size 1 at addr ffff888019be7ddf by task writefile/3787

  CPU: 4 PID: 3787 Comm: writefile Not tainted 5.16.0-rc7+ #12
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014

due to accessing buf one char before its start.

Prevent such out-of-bounds access.

  [ bp: Productize into a proper patch. Link below is the next best
    thing because the original mail didn't get archived on lore. ]

Fixes: 0451d14d0561 ("EDAC, mce_amd_inj: Modify flags attribute to use string arguments")
Signed-off-by: Zhang Zixun <zhang133010@icloud.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/linux-edac/YcnePfF1OOqoQwrX@zn.tnic/
arch/x86/kernel/cpu/mce/inject.c