OSDN Git Service

drm/i915: Reject excessive dotclocks early
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 27 Sep 2022 18:24:55 +0000 (21:24 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 3 Oct 2022 15:46:37 +0000 (18:46 +0300)
commitdf2f59c5857b56a5cc40b6562b032c5d8d50cdfc
treec6c47f6e66aafa195b394b15cc7924ce8458dee7
parentd5c45330c8986aff945de997383e19b5b7a85b9a
drm/i915: Reject excessive dotclocks early

Make sure modes with crazy big dotclocks are rejected early,
so as to not cause problems for subsequent code via integer
overflows and whatnot.

These would eventually be rejected in intel_crtc_compute_pipe_mode()
but that is now too late as we do the clock computations a bit
earlier than that. And we don't want to just reorder the two since
we still want to check the final computed dotclock against the
hardware limit to make sure we didn't end up above the limit due
to rounding/etc.

Fixes: 0ff0e219d9b8 ("drm/i915: Compute clocks earlier")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220927182455.3422-1-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_display.c