OSDN Git Service

powerpc/boot: Use address-of operator on section symbols
authorNathan Chancellor <natechancellor@gmail.com>
Wed, 24 Jun 2020 03:59:20 +0000 (20:59 -0700)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 30 Jun 2020 04:38:00 +0000 (14:38 +1000)
commitdf4232d96e724d09e54a623362f9f610727f059f
tree7489e2604f69391b04905162eb38034079f463c6
parent1addb6444791f9e87fce0eb9882ec96a4a76e615
powerpc/boot: Use address-of operator on section symbols

Clang warns:

arch/powerpc/boot/main.c:107:18: warning: array comparison always
evaluates to a constant [-Wtautological-compare]
        if (_initrd_end > _initrd_start) {
                        ^
arch/powerpc/boot/main.c:155:20: warning: array comparison always
evaluates to a constant [-Wtautological-compare]
        if (_esm_blob_end <= _esm_blob_start)
                          ^
2 warnings generated.

These are not true arrays, they are linker defined symbols, which are
just addresses.  Using the address of operator silences the warning
and does not change the resulting assembly with either clang/ld.lld
or gcc/ld (tested with diff + objdump -Dr).

Reported-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200624035920.835571-1-natechancellor@gmail.com
arch/powerpc/boot/main.c
arch/powerpc/boot/ps3.c