OSDN Git Service

stmmac: fix check for phydev being open
authorAlexey Brodkin <Alexey.Brodkin@synopsys.com>
Wed, 9 Sep 2015 15:01:08 +0000 (18:01 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 Sep 2015 00:07:43 +0000 (17:07 -0700)
commitdfc50fcaad574e5c8c85cbc83eca1426b2413fa4
treeee257cfea4f0d54ec756c7d98b0cb671e7a1b566
parent1f0ca208531a152e1da6aa43d095fe0b2039d9ca
stmmac: fix check for phydev being open

Current check of phydev with IS_ERR(phydev) may make not much sense
because of_phy_connect() returns NULL on failure instead of error value.

Still for checking result of phy_connect() IS_ERR() makes perfect sense.

So let's use combined check IS_ERR_OR_NULL() that covers both cases.

Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c