OSDN Git Service

Revert "drm/shmem-helper: Switch to reservation lock"
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 28 Feb 2023 15:26:12 +0000 (16:26 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 28 Feb 2023 15:41:32 +0000 (16:41 +0100)
commite0106ac97886b6bc36c480de72562d3e70b3f8b1
tree0dd0cdd216af7dbb5d38203b8f6776a5ada13163
parentf9b9297b1facb636ee81f03be3658087067babc2
Revert "drm/shmem-helper: Switch to reservation lock"

This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0.

The locking appears incomplete. A caller of SHMEM helper's pin
function never acquires the dma-buf reservation lock. So we get

  WARNING: CPU: 3 PID: 967 at drivers/gpu/drm/drm_gem_shmem_helper.c:243 drm_gem_shmem_pin+0x42/0x90 [drm_shmem_helper]

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230228152612.19971-1-tzimmermann@suse.de
drivers/gpu/drm/drm_gem_shmem_helper.c
drivers/gpu/drm/lima/lima_gem.c
drivers/gpu/drm/panfrost/panfrost_drv.c
drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c
drivers/gpu/drm/panfrost/panfrost_mmu.c
include/drm/drm_gem_shmem_helper.h