OSDN Git Service

drm/vc4: hdmi: Fix error path of hpd-gpios
authorMaxime Ripard <maxime@cerno.tech>
Mon, 24 May 2021 13:18:51 +0000 (15:18 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 7 Jun 2021 11:33:46 +0000 (13:33 +0200)
commite075a7811977ff51c917a65ed1896e08231d2615
treecf0a4a0ecd0f25ad87c444b8fc10a8c7f1b445cb
parent8f8e19bd18b41dae7a9192c29cba9298bafcde10
drm/vc4: hdmi: Fix error path of hpd-gpios

If the of_get_named_gpio_flags call fails in vc4_hdmi_bind, we jump to
the err_unprepare_hsm label. That label will then call
pm_runtime_disable and put_device on the DDC device.

We just retrieved the DDC device, so the latter is definitely justified.
However at that point we still haven't called pm_runtime_enable, so the
call to pm_runtime_disable is not supposed to be there.

Fixes: 10ee275cb12f ("drm/vc4: prepare for CEC support")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210524131852.263883-1-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_hdmi.c