OSDN Git Service

drm/i915: Use __intel_uncore_wait_for_register_fw for sandybride_pcode_read
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 11 Apr 2017 10:13:39 +0000 (11:13 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 11 Apr 2017 11:47:17 +0000 (12:47 +0100)
commite09a3036412a959689bacf017bf2cbc226c9fea4
tree991e2c564f75123d4fea6440e88563c3b40b2412
parent0564654340e2776843ade007c1aaa8e8f30dd147
drm/i915: Use __intel_uncore_wait_for_register_fw for sandybride_pcode_read

Since the sandybridge_pcode_read() may be called from
skl_pcode_request() inside an atomic context (with preempt disabled), we
should avoid hitting any sleeping paths. Currently is being called with
a 500ms timeout, irrespective of being inside an atomic context or not.
This is reduced down to 500us to play nice with the atomic context, and
that appears to be sufficient to keep BAT happy (we have a DRM_ERROR
should it timeout), i.e. we do not see any 500us pcode timeouts for
normal use. So leave it as a pure spin without having to introduce new
code paths to separate atomic/normal contexts.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170411101340.31994-4-chris@chris-wilson.co.uk
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
drivers/gpu/drm/i915/intel_pm.c