OSDN Git Service

drm/etnaviv: avoid cleaning up sched_job when submit succeeded
authorLucas Stach <l.stach@pengutronix.de>
Wed, 4 May 2022 09:02:29 +0000 (11:02 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 4 May 2022 12:09:34 +0000 (14:09 +0200)
commite123b4edb2a13b67c4de7caee2e3d5e083bef58b
tree2951d764330c4bec1e5c202e24d7e8df3f8e2193
parent420f95b0ad603165684528276ca9bf1a290bfb4e
drm/etnaviv: avoid cleaning up sched_job when submit succeeded

While the labels may mislead the casual reader, the tail of the function
etnaviv_ioctl_gem_submit is always executed, as a lot of the structures
set up in this function need to be cleaned up regardless of whether the
submit succeeded or failed.

An exception is the newly added drm_sched_job_cleanup, which must only
be called when the submit failed before handing the job to the
scheduler.

Fixes: b827c84f5e84 ("drm/etnaviv: Use scheduler dependency handling")
Reported-by: Michael Walle <michael@walle.cc>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220504090229.2506560-1-l.stach@pengutronix.de
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c