OSDN Git Service

block/replication.c: Avoid cancelling the job twice
authorLukas Straub <lukasstraub2@web.de>
Mon, 11 May 2020 07:08:01 +0000 (09:08 +0200)
committerKevin Wolf <kwolf@redhat.com>
Mon, 18 May 2020 17:05:25 +0000 (19:05 +0200)
commite140f4b7b8c0fdda866ba3d8b4aa184b6ba6d6b8
tree9b72a7f2703fa404d4a63cac58fa69bdd1aaa4c1
parent16cea4ee1c8e5a69a058e76f426b2e17974d8d7d
block/replication.c: Avoid cancelling the job twice

If qemu in colo secondary mode is stopped, it crashes because
s->backup_job is canceled twice: First with job_cancel_sync_all()
in qemu_cleanup() and then in replication_stop().

Fix this by assigning NULL to s->backup_job when the job completes
so replication_stop() and replication_do_checkpoint() won't touch
the job.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Message-Id: <20200511090801.7ed5d8f3@luklap>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/replication.c