OSDN Git Service

qemu-nbd: changes towards enabling -Wshadow=local
authorEric Blake <eblake@redhat.com>
Fri, 22 Sep 2023 20:50:20 +0000 (15:50 -0500)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 29 Sep 2023 08:07:20 +0000 (10:07 +0200)
commite161785c05c8a96962a0ea87a3abefe158d8b035
treeb49fbec1f6d61e036ae563f3e933cf1490bca47e
parent0d57919acf27ca343981f69cec33463887e0a716
qemu-nbd: changes towards enabling -Wshadow=local

Address all compiler complaints from -Wshadow in qemu-nbd.  Several
instances of 'int ret' became shadows when commit 4fbec260 added 'ret'
at a higher scope in main.  More interesting was the 'void *ret'
capturing the result of a pthread; where we were conceptually doing
'(void*)(intptr_t)EXIT_FAILURE != NULL' which just feels wrong (even
though it happens to compile correctly), so it was worth a better
cleanup.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-ID: <20230922205019.2755352-2-eblake@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
qemu-nbd.c