OSDN Git Service

bitops: use try_cmpxchg in set_mask_bits and bit_clear_unless
authorUros Bizjak <ubizjak@gmail.com>
Mon, 22 Aug 2022 14:38:51 +0000 (16:38 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 Sep 2022 04:55:09 +0000 (21:55 -0700)
commite1d7c7609ae0933b59840390c1b207ac0a925c8b
tree55170982bc11f6e761a136a01649c1ccc5e92d1b
parent21490eff121555b123f7088b935e40ee43d2c642
bitops: use try_cmpxchg in set_mask_bits and bit_clear_unless

Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
set_mask_bits and bit_clear_unless.  x86 CMPXCHG instruction returns
success in ZF flag, so this change saves a compare after cmpxchg (and
related move instruction in front of cmpxchg).

Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
fails, enabling further code simplifications.

Link: https://lkml.kernel.org/r/20220822143851.3290-1-ubizjak@gmail.com
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/bitops.h