OSDN Git Service

xhci: Fix error path return value.
authorSarah Sharp <sarah.a.sharp@linux.intel.com>
Thu, 7 Jun 2012 18:10:32 +0000 (11:10 -0700)
committerSarah Sharp <sarah.a.sharp@linux.intel.com>
Wed, 13 Jun 2012 23:37:25 +0000 (16:37 -0700)
commite25e62aecac42379e113c63a674a86ae3ebbec8d
tree8f2a448e314790ff1f65644f0bc84f140badb9cb
parent55558c33d6d46cb6f426b729f4119e3b2f12f02b
xhci: Fix error path return value.

This patch fixes an issue discovered by Dan Carpenter:

The patch 3b3db026414b: "xhci: Add infrastructure for host-specific
LPM policies." from May 9, 2012, leads to the following warning:
drivers/usb/host/xhci.c:3909 xhci_get_timeout_no_hub_lpm()
         warn: signedness bug returning '-22'

  3906          default:
  3907                  dev_warn(&udev->dev, "%s: Can't get timeout for non-U1 or U2 state.\n",
  3908                                  __func__);
  3909                  return -EINVAL;
                        ^^^^^^^^^^^^^^
This should be a u16 like USB3_LPM_DISABLED or something.

  3910          }
  3911
  3912          if (sel <= max_sel_pel && pel <= max_sel_pel)
  3913                  return USB3_LPM_DEVICE_INITIATED;

Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
drivers/usb/host/xhci.c