OSDN Git Service

KVM: arm64: Correctly treat writes to OSLSR_EL1 as undefined
authorOliver Upton <oupton@google.com>
Thu, 3 Feb 2022 17:41:54 +0000 (17:41 +0000)
committerMarc Zyngier <maz@kernel.org>
Tue, 8 Feb 2022 14:23:40 +0000 (14:23 +0000)
commite2ffceaae50883c5064641167078e5720fd8b74a
tree70f5aff4764a101d5d072ab84bdbb55b5c93f750
parentdfd42facf1e4ada021b939b4e19c935dcdd55566
KVM: arm64: Correctly treat writes to OSLSR_EL1 as undefined

Writes to OSLSR_EL1 are UNDEFINED and should never trap from EL1 to
EL2, but the kvm trap handler for OSLSR_EL1 handles writes via
ignore_write(). This is confusing to readers of code, but should have
no functional impact.

For clarity, use write_to_read_only() rather than ignore_write(). If a
trap is unexpectedly taken to EL2 in violation of the architecture, this
will WARN_ONCE() and inject an undef into the guest.

Reviewed-by: Reiji Watanabe <reijiw@google.com>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
[adopted Mark's changelog suggestion, thanks!]
Signed-off-by: Oliver Upton <oupton@google.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220203174159.2887882-2-oupton@google.com
arch/arm64/kvm/sys_regs.c