OSDN Git Service

HID: logitech-dj: remove false-positive error on double queueing of delayed-work
authorHans de Goede <hdegoede@redhat.com>
Sat, 20 Apr 2019 11:22:01 +0000 (13:22 +0200)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tue, 23 Apr 2019 16:02:01 +0000 (18:02 +0200)
commite316aa6e545f0bae82776317bf08ced79a68047d
treedf7b1041d8f87c7afd2b6c0cc6ea9629d27b2482
parentde76b1d3332d53ccb1d3600b22a83e7e7b8f0b76
HID: logitech-dj: remove false-positive error on double queueing of delayed-work

The various functions queueing work-items do not check there already is a
work-item queued before calling schedule_work(), as such they may race
with each-other and with the re-queuing done by the delayedwork_callback
itself.

This is fine as the delayedwork_callback simply is a nop if scheduled once
too much. I've actually seen the false-positive hid_err for this trigger
in practice, so lets remove it.

While at it also remove the somewhat overzealous debugging around the
schedule_work() calls.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/hid-logitech-dj.c