OSDN Git Service

b43: fix unitialized reads of ret by initializing the array to zero
authorColin Ian King <colin.king@canonical.com>
Tue, 5 Sep 2017 18:15:50 +0000 (19:15 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 20 Sep 2017 12:41:07 +0000 (15:41 +0300)
commite31fbe1034d9066cfff0d0a4f7ce440ddf75643f
tree6076dd08e03b3a5a4647a61f4a3a10a8bfd37683
parent6508497cbdc70b92130fbca57402af6a94e05d20
b43: fix unitialized reads of ret by initializing the array to zero

The u8 char array ret is not being initialized and elements outside
the range start to end contain just garbage values from the stack.
This results in a later scan of the array to read potentially
uninitialized values.  Fix this by initializing the array to zero.
This seems to have been an issue since the very first commit.

Detected by CoverityScan CID#139652 ("Uninitialized scalar variable")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Michael Buesch <m@bues.ch>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/b43/phy_g.c