OSDN Git Service

drm/vc4: hdmi: Fix HPD GPIO detection
authorMaxime Ripard <maxime@cerno.tech>
Mon, 25 Oct 2021 15:28:55 +0000 (17:28 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Thu, 4 Nov 2021 09:36:25 +0000 (10:36 +0100)
commite32e5723256a99c5324824503572f743377dd0fe
tree6a7b76b49d4df63064d00fb20224fcb4331846ab
parentcc5f1cbbc1e12ad5b11d594159fe793eb03c70fa
drm/vc4: hdmi: Fix HPD GPIO detection

Prior to commit 6800234ceee0 ("drm/vc4: hdmi: Convert to gpiod"), in the
detect hook, if we had an HPD GPIO we would only rely on it and return
whatever state it was in.

However, that commit changed that by mistake to only consider the case
where we have a GPIO and it returns a logical high, and would fall back
to the other methods otherwise.

Since we can read the EDIDs when the HPD signal is low on some displays,
we changed the detection status from disconnected to connected, and we
would ignore an HPD pulse.

Fixes: 6800234ceee0 ("drm/vc4: hdmi: Convert to gpiod")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://lore.kernel.org/r/20211025152903.1088803-3-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_hdmi.c