OSDN Git Service

rtc: ds1307: Enable the mcp794xx alarm after programming time
authorNishanth Menon <nm@ti.com>
Tue, 21 Apr 2015 00:51:34 +0000 (19:51 -0500)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Wed, 24 Jun 2015 23:13:46 +0000 (01:13 +0200)
commite3edd67141a1ea5294e54b17fee5becf1090f5d4
treebd66e6f402abcb86de94252d77bd7bf3a4ace9c9
parent4be1f6bbd1e968ab02653c28eababd9480dfff77
rtc: ds1307: Enable the mcp794xx alarm after programming time

Alarm interrupt enable register is at offset 0x7, while the time
registers for the alarm follow that. When we program Alarm interrupt
enable prior to programming the time, it is possible that previous
time value could be close or match at the time of alarm enable
resulting in interrupt trigger which is unexpected (and does not match
the time we expect it to trigger).

To prevent this scenario from occuring, program the ALM0_EN bit only
after the alarm time is appropriately programmed.

Ofcourse, I2C programming is non-atomic, so there are loopholes where
the interrupt wont trigger if the time requested is in the past at
the time of programming the ALM0_EN bit. However, we will not have
unexpected interrupts while the time is programmed after the interrupt
are enabled.

Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@linaro.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-ds1307.c