OSDN Git Service

media: gspca: Fix memory leak in probe
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 2 Dec 2020 17:20:04 +0000 (18:20 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 7 Dec 2020 14:00:15 +0000 (15:00 +0100)
commite469d0b09a19496e1972a20974bbf55b728151eb
tree4f687619c64c65de9e11d1a2e352c7cad723d027
parent2b006e748c81da1b32029257d003f9b2af7435a5
media: gspca: Fix memory leak in probe

The gspca driver leaks memory when a probe fails.  gspca_dev_probe2()
calls v4l2_device_register(), which takes a reference to the
underlying device node (in this case, a USB interface).  But the
failure pathway neglects to call v4l2_device_unregister(), the routine
responsible for dropping this reference.  Consequently the memory for
the USB interface and its device never gets released.

This patch adds the missing function call.

Reported-and-tested-by: syzbot+44e64397bd81d5e84cba@syzkaller.appspotmail.com
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: <stable@vger.kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/gspca/gspca.c