OSDN Git Service

reset: imx7: Fix always writing bits as 0
authorLeonard Crestez <leonard.crestez@nxp.com>
Fri, 20 Jul 2018 12:47:43 +0000 (15:47 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Sep 2018 06:39:27 +0000 (08:39 +0200)
commite505be5d53e0ae6320fbd0f6f4357773afa30977
tree27ed9fdf526033d8bfefb65a1d078e078c47e145
parentcf29c5b3d33975b0eaf08b2ddfd9594c9f5c0e8c
reset: imx7: Fix always writing bits as 0

[ Upstream commit 26fce0557fa639fb7bbc33e31a57cff7df25c3a0 ]

Right now the only user of reset-imx7 is pci-imx6 and the
reset_control_assert and deassert calls on pciephy_reset don't toggle
the PCIEPHY_BTN and PCIEPHY_G_RST bits as expected. Fix this by writing
1 or 0 respectively.

The reference manual is not very clear regarding SRC_PCIEPHY_RCR but for
other registers like MIPIPHY and HSICPHY the bits are explicitly
documented as "1 means assert, 0 means deassert".

The values are still reversed for IMX7_RESET_PCIE_CTRL_APPS_EN.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/reset/reset-imx7.c