OSDN Git Service

drm: Move vblank cleanup from unregister to release
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Wed, 14 Dec 2016 10:41:24 +0000 (12:41 +0200)
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 19 Dec 2016 09:25:05 +0000 (11:25 +0200)
commite57e17cc40d3297fbb279c6c0e9613bdc81ef893
treea5173ccd8a251f85f80d2e652fd22e1c1691c7ef
parentd501b12999eb9cdfc488127fabaf794171dd9bbf
drm: Move vblank cleanup from unregister to release

Calling drm_vblank_cleanup() in drm_dev_unregister() causes issues with
drivers that have moved away from the .load() and .unload() midlayer.
Those drivers call drm_dev_unregister() as the first operation at unbind
time, before shutting down the device. This results in warnings due to
drm_vblank_cleanup() being called with vblank interrupts still active,
and then to vblank events being sent after cleanup.

Fix the problem by moving vblank cleanup from drm_dev_unregister() to
drm_dev_release() that is guaranteed to be called after drivers shut
down the device.

Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
drivers/gpu/drm/drm_drv.c