OSDN Git Service

target/ppc: Don't update radix PTE R/C bits with gdbstub
authorGreg Kurz <groug@kaod.org>
Wed, 13 May 2020 22:57:19 +0000 (00:57 +0200)
committerDavid Gibson <david@gibson.dropbear.id.au>
Wed, 27 May 2020 05:29:36 +0000 (15:29 +1000)
commite606a5580131855ce79f1f585e91ac0b6dd805ae
tree62d7f88e79b1e3c4cfa25f2cc7f19ca8d1fc855a
parent31efae9958a8a085d248a74a9448048bac5d6e68
target/ppc: Don't update radix PTE R/C bits with gdbstub

gdbstub shouldn't silently change guest visible state when doing address
translation. Since the R/C bits can only be updated when handling a MMU
fault, let's reuse the cause_excp flag and rename it to guest_visible.
While here drop a not very useful comment.

This was found while reading the code. I could verify that this affects
both powernv and pseries, but I failed to observe any actual bug.

Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped translation"
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <158941063899.240484.2778628492106387793.stgit@bahia.lan>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
target/ppc/mmu-radix64.c