OSDN Git Service

mm/kmemleak: move up cond_resched() call in page scanning loop
authorWaiman Long <longman@redhat.com>
Fri, 25 Aug 2023 16:49:47 +0000 (12:49 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 2 Sep 2023 22:17:34 +0000 (15:17 -0700)
commite68d343d2720779362cb7160cb7f4bd24979b2b4
treef5f56525ff09ad3e80f5e2463ab9195b3a1859f1
parentf945116e4e191cd543ecd56d9f13e6331494847c
mm/kmemleak: move up cond_resched() call in page scanning loop

Commit bde5f6bc68db ("kmemleak: add scheduling point to kmemleak_scan()")
added a cond_resched() call to the struct page scanning loop to prevent
soft lockup from happening.  However, soft lockup can still happen in that
loop in some corner cases when the pages that satisfy the "!(pfn & 63)"
check are skipped for some reasons.

Fix this corner case by moving up the cond_resched() check so that it will
be called every 64 pages unconditionally.

Link: https://lkml.kernel.org/r/20230825164947.1317981-1-longman@redhat.com
Fixes: bde5f6bc68db ("kmemleak: add scheduling point to kmemleak_scan()")
Signed-off-by: Waiman Long <longman@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Yisheng Xie <xieyisheng1@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/kmemleak.c