OSDN Git Service

nfp: fix fw dump handling of absolute rtsym size
authorCarl Heymann <carl.heymann@netronome.com>
Tue, 23 Jan 2018 01:29:43 +0000 (17:29 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Jan 2018 15:12:01 +0000 (10:12 -0500)
commite71494ae68d2cbade38bbc2935cd7ff96e2b9b04
treee2944b52aba27ae1acfe8f1f92eff65fd82ea512
parentc13da21cdb8085f1d9a53463c88a4d3967fe90fd
nfp: fix fw dump handling of absolute rtsym size

Fix bug that causes _absolute_ rtsym sizes of > 8 bytes (as per symbol
table) to result in incorrect space used during a TLV-based debug dump.

Detail: The size calculation stage calculates the correct size (size of
the rtsym address field == 8), while the dump uses the size in the table
to calculate the TLV size to reserve. Symbols with size <= 8 are handled
OK due to aligning sizes to 8, but including any absolute symbol with
listed size > 8 leads to an ENOSPC error during the dump.

Fixes: da762863edd9 ("nfp: fix absolute rtsym handling in debug dump")
Signed-off-by: Carl Heymann <carl.heymann@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net_debugdump.c