OSDN Git Service

ASoC: qdsp6: q6core: Use struct_size() in kmemdup()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 23 May 2019 16:07:48 +0000 (11:07 -0500)
committerMark Brown <broonie@kernel.org>
Fri, 24 May 2019 12:01:57 +0000 (13:01 +0100)
commite718a3eb09ae491147ded7e2e923ba6de59f0b24
tree461d72a908ce953a84528c11ecf558fc887f931f
parentd00cc2f16a41ee704113f9447f2d0a10ad4f0ec7
ASoC: qdsp6: q6core: Use struct_size() in kmemdup()

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.

So, replace code of the following form:

sizeof(*fwk) + fwk->num_services * sizeof(fwk->svc_api_info[0]);

with:

struct_size(fwk, svc_api_info, fwk->num_services)

and so on...

Notice that variables bytes and len are unnecessary, hence they are
removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/qdsp6/q6core.c