OSDN Git Service

hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close
authorJia-Ju Bai <baijiaju1990@163.com>
Tue, 12 Dec 2017 08:49:52 +0000 (16:49 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Feb 2018 10:05:50 +0000 (11:05 +0100)
commite767d353299a9be2acaa0dd618fdedefff184546
tree27713216fefe657da9d0be89bc2cfbff9f49dccf
parentd295bb9993524119cdca6226dafa76a448a4c71b
hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close

[ Upstream commit 6e266610eb6553cfb7e7eb5d11914bd01509c406 ]

The driver may sleep under a spinlock.
The function call path is:
rr_close (acquire the spinlock)
  free_irq --> may sleep

To fix it, free_irq is moved to the place without holding the spinlock.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/hippi/rrunner.c