OSDN Git Service

i386/xen: fix per-vCPU upcall vector for Xen emulation
authorDavid Woodhouse <dwmw@amazon.co.uk>
Wed, 11 Oct 2023 22:30:08 +0000 (23:30 +0100)
committerDavid Woodhouse <dwmw@amazon.co.uk>
Mon, 6 Nov 2023 10:03:45 +0000 (10:03 +0000)
commite7dbb62ff19ce55548c785d76e814e7b144e6217
treeb4db81997e73b3a792a284a5ab3a0cf7ee017408
parente969f992c6562222e245dd8557f5b132a11ec29c
i386/xen: fix per-vCPU upcall vector for Xen emulation

The per-vCPU upcall vector support had three problems. Firstly it was
using the wrong hypercall argument and would always return -EFAULT when
the guest tried to set it up. Secondly it was using the wrong ioctl() to
pass the vector to the kernel and thus the *kernel* would always return
-EINVAL. Finally, even when delivering the event directly from userspace
with an MSI, it put the destination CPU ID into the wrong bits of the
MSI address.

Linux doesn't (yet) use this mode so it went without decent testing
for a while.

Cc: qemu-stable@nongnu.org
Fixes: 105b47fdf2d0 ("i386/xen: implement HVMOP_set_evtchn_upcall_vector")
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Paul Durrant <paul@xen.org>
target/i386/kvm/xen-emu.c