OSDN Git Service

usb: dwc3: don't reset device side if dwc3 was configured as host-only
authorJisheng Zhang <jszhang@kernel.org>
Tue, 27 Jun 2023 16:20:18 +0000 (00:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Jul 2023 15:39:58 +0000 (17:39 +0200)
commite835c0a4e23c38531dcee5ef77e8d1cf462658c7
tree966be6863702c831e125ded971154d0fc5edf185
parent71c47ad8920ef19d6545202191252a50c03aca30
usb: dwc3: don't reset device side if dwc3 was configured as host-only

Commit c4a5153e87fd ("usb: dwc3: core: Power-off core/PHYs on
system_suspend in host mode") replaces check for HOST only dr_mode with
current_dr_role. But during booting, the current_dr_role isn't
initialized, thus the device side reset is always issued even if dwc3
was configured as host-only. What's more, on some platforms with host
only dwc3, aways issuing device side reset by accessing device register
block can cause kernel panic.

Fixes: c4a5153e87fd ("usb: dwc3: core: Power-off core/PHYs on system_suspend in host mode")
Cc: stable <stable@kernel.org>
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20230627162018.739-1-jszhang@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/core.c